eolivelli commented on pull request #9590: URL: https://github.com/apache/pulsar/pull/9590#issuecomment-780172178
@sijie I totally agree that the main point here is to prevent the PulsarSink from creating the Producer and forcing a Schema on the topic in case of `GenericRecord` type. So I am fine with this approach as well. if you are okay I can merge this patch in my branch at #9481 (and revert the changes to TopicSchema) as we already have integration tests and I can continue the work. But if you prefer I can close my PR and let you complete your patch, but please add an integration test like my one (that basically covers my usecase). I just want to see this feature land to master branch and make it available to our users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
