congbobo184 commented on a change in pull request #9630:
URL: https://github.com/apache/pulsar/pull/9630#discussion_r579634218
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericAvroReader.java
##########
@@ -66,7 +66,7 @@ public GenericAvroReader(Schema writerSchema, Schema
readerSchema, byte[] schema
this.reader = new GenericDatumReader<>(writerSchema, readerSchema);
}
this.byteArrayOutputStream = new ByteArrayOutputStream();
- this.encoder =
EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, encoder);
+ this.encoder =
EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, null);
Review comment:
It doesn't make any sense, the encoder in this time is always null. same
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
