Jennifer88huang commented on a change in pull request #9651:
URL: https://github.com/apache/pulsar/pull/9651#discussion_r579908819



##########
File path: site2/docs/admin-api-overview.md
##########
@@ -87,4 +87,22 @@ PulsarAdmin admin = PulsarAdmin.builder()
 ## How to define Pulsar resource names when running Pulsar in Kubernetes
 If you run Pulsar Functions or connectors on Kubernetes, you need to follow 
Kubernetes naming convention to define the names of your Pulsar resources, 
whichever admin interface you use.
 
-Kubernetes requires a name that can be used as a DNS subdomain name as defined 
in [RFC 
1123](https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names).
 Pulsar supports more legal characters than Kubernetes naming convention. If 
you create a Pulsar resource name with special characters that is not supported 
by Kubernetes (for example, including colons in a Pulsar namespace name), you 
cannot run functions or connectors using Kubernetes runtime.
\ No newline at end of file
+Kubernetes requires a name that can be used as a DNS subdomain name as defined 
in [RFC 
1123](https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names).
 Pulsar supports more legal characters than Kubernetes naming convention. If 
you create a Pulsar resource name with special characters that is not supported 
by Kubernetes (for example, including colons in a Pulsar namespace name), 
KubernetesRuntime translates the Pulsar object names to the RFC1123-compliant 
forms for Kubernetes resource labels. Consequently, you can run functions or 
connectors using Kubernetes runtime. The rules for translating Pulsar object 
names to Kubernetes resource labels are as below:
+
+- Truncate to 63 characters
+  
+- Replace the following characters with dashes (-):
+  
+  - Non alphanumeric characters ([a-z0-9A-Z])
+  
+  - Underscores (_)
+  
+  - Dot (.) 
+  
+- Replace beginning and end non-alphanumeric characters with 0
+  
+> #### Tip

Review comment:
       Yes, for "note/tip", we use bold font for them, see 
https://developers.google.com/style/notices
   Besides, heading is used to clarify the structure; usually we do not skip 
levels of the heading hierarchy, see 
https://developers.google.com/style/headings
   So it's better to use bold font for note/tip rather than heading.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to