sijie commented on a change in pull request #9631:
URL: https://github.com/apache/pulsar/pull/9631#discussion_r579370010
##########
File path:
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java
##########
@@ -560,6 +563,18 @@ public boolean advanceNextPosition() {
return true;
}
+ private SchemaInfo getBytesSchemaInfo(SchemaType schemaType, String
schemaName) {
+ if (!schemaType.equals(SchemaType.BYTES) &&
!schemaType.equals(SchemaType.NONE)) {
+ return null;
+ }
+ if (schemaName.equals(Schema.BYTES.getSchemaInfo().getName())) {
Review comment:
Can you compare SchemaType instead of comparing schemaName?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
