lhotari opened a new pull request #9672:
URL: https://github.com/apache/pulsar/pull/9672


   ### Motivation
   
   Integration test classes misuse BeforeSuite and AfterSuite annotations. When 
AfterSuite is used to cleanup resources, it results in resources piling up for 
the duration of the complete test suite run. It's like a memory leak since 
resources aren't properly cleaned up during test execution. 
   
   Some test classes implemented ITest, which caused misleading error messages 
from TestNG. There shouldn't be a need to implement ITest.
   
   Besides the annotation issue, some resources were using static fields 
without a real reason.
   
   ### Modifications
   
   - replace BeforeSuite -> BeforeClass and AfterSuite -> AfterClass
   - remove `implements ITest`
   - use instance fields instead of static fields. drop "static" from the 
methods that reference these fields.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to