PowerStateFailure opened a new pull request #473: URL: https://github.com/apache/pulsar-client-go/pull/473
Master Issue: #462 ### Motivation As mentioned in [this comment](https://github.com/apache/pulsar-client-go/issues/462#issuecomment-780357151), when connection closed, one of its goroutine stucks within `failLeftRequestsWhenClose` method as `incomingRequestsCh` gets never closed. This simple PR swaps order of operation done in this method so that it first closes the channel (as buffered chan used, it's perfectly valid and no data ever lost) and thaen handles any message left in `incomingRequestsCh` channel. ### Modifications Mentioned above. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) ### Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
