merlimat commented on pull request #9649: URL: https://github.com/apache/pulsar/pull/9649#issuecomment-784389764
> Looks good to me, could you please add a test for the new metrics? Avoid breaking it in future versions The metrics are static in the broker so it's very difficult to test them cleanly in isolation when the unit tests are running multiple broker instances ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
