merlimat commented on a change in pull request #9638:
URL: https://github.com/apache/pulsar/pull/9638#discussion_r581300349
##########
File path: pulsar-io/aerospike/pom.xml
##########
@@ -36,16 +36,19 @@
<groupId>${project.groupId}</groupId>
<artifactId>pulsar-io-core</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
+ <scope>provided</scope>
Review comment:
Gotcha. As a side note, we could provide here a standard method to
perform the yaml ser/de since most (all?) connectors are going to do this.
This way, the connector don't need to depend on that and the serialization
code is already embedded in the runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
