jerrypeng commented on a change in pull request #9689:
URL: https://github.com/apache/pulsar/pull/9689#discussion_r581442335



##########
File path: pulsar-client-admin-shaded/pom.xml
##########
@@ -66,6 +66,7 @@
                   <include>org.apache.pulsar:pulsar-client-original</include>
                   <include>org.apache.pulsar:pulsar-client-api</include>
                   
<include>org.apache.pulsar:pulsar-client-admin-original</include>
+                  <include>org.apache.pulsar:pulsar-client-admin-api</include>

Review comment:
       @merlimat `pulsar-client-api` is included as well.  The problem is with 
shading. If pulsar-client-admin-api is not included in the shaded JAR and is 
just pull in as a transitive dependency errors like
   
   `java.lang.NoSuchMethodError: 
org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V`
   
   will occur because the impl will be using the shaded version classes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to