dlg99 commented on a change in pull request #9729:
URL: https://github.com/apache/pulsar/pull/9729#discussion_r583778757
##########
File path: pom.xml
##########
@@ -124,7 +124,7 @@ flexible messaging model and an intuitive client
API.</description>
<typetools.version>0.5.0</typetools.version>
<protobuf3.version>3.11.4</protobuf3.version>
<protoc3.version>${protobuf3.version}</protoc3.version>
- <grpc.version>1.18.0</grpc.version>
+ <grpc.version>1.33.0</grpc.version>
Review comment:
@eolivelli Etcd client broke because grpc 1.36 depends on netty 1.52.
From what I understood, the culprit was was this change
https://github.com/netty/netty/pull/10407 in 4.1.52 that got reverted
https://github.com/netty/netty/pull/10980
The change got reverted because `TLS_FALSE_START slightly changes the
"flow" during handshake which may cause suprises for the end-user`
We can try mixing netty 1.51 (or 1.59, where the change is supposedly
reverted, it was not out when I tested bookkeeper) with grpc 1.36 but I am not
sure how much I can rely on existing tests (and many of them don't pass
currently anyways, with or without my changes). I'd very much prefer not to
experiment with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
