aloyszhang edited a comment on pull request #9743:
URL: https://github.com/apache/pulsar/pull/9743#issuecomment-786789928


   @eolivelli 
   Actually, the default generated  deadLetterTopic are not consistent from 
ConsumerImpl
   ```java
     .deadLetterTopic(String.format("%s-%s" + 
RetryMessageUtil.DLQ_GROUP_TOPIC_SUFFIX, topic, subscription))
   ```
   and ConsumerBuilderImpl
   ```java
   String retryLetterTopic = topicFirst.getNamespace() + "/" + 
conf.getSubscriptionName() + RetryMessageUtil.RETRY_GROUP_TOPIC_SUFFIX;
   ```
   So, IMO, it's better to unite the format of default retryLetterTopic and 
deadLetterTopic and fix the potential risk for consumer to receive extra 
message from topics it does not subscribe although we have to adjustment out 
application.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to