michaeljmarshall opened a new pull request #9751:
URL: https://github.com/apache/pulsar/pull/9751


   Fixes (part of) #9725
   
   ### Motivation
   
   Fixes a memory leak for transactions.
   
   ### Modifications
   
   The `ReadEntryCallback` should release the `entry` passed to it. I validated 
that other implementations of the `ReadEntryCallback` class release the 
`entry`. Further, the final stack trace referenced in #9725 has clear 
references to this stack. The only change is to call `entry.release()`. Because 
parsing could lead to an exception, I used a `finally` block.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage. 
(We must not have test coverage for this type of leak, though.)
   
   ### Cherry Pick
   
   This PR fixes a memory leak in master (that is also in 2.7.0). We'll want to 
make sure this makes it into the `2.7.1` release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to