eolivelli commented on pull request #9740:
URL: https://github.com/apache/pulsar/pull/9740#issuecomment-787853689
I am fine with having the HashMap and use it consistently.
so +1 from me to this patch.
This is definitely a good idea.
Using TreeMap consistently is okay as well, but if usually we have an
HashMap (in the majority of cases) it is better to go with HashMap.
It would be better to have some way to ensure that we won't change it again
in the future with some refactor.
So I don't see this patch as a direct fix for the test.
by the way I share @lhotari concerns, we should add explicit checks about
security/auth data structures and consistency of the runtime environment.
so probably the best is to have both of the two patches merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
