lhotari edited a comment on pull request #9764:
URL: https://github.com/apache/pulsar/pull/9764#issuecomment-788764981
> what about changing to the new method only in the cases that are relevant
to the deadlocks you see in the test ?
@eolivelli Why limit to the cases that happen to show up? Matteo commented
earlier: "We shouldn't be doing blocking calls from within the process method.
I think we should rather refactor that code instead." Based on this rule, it
can be determined from the code whether a certain usage of `.forEach` needs
addressing or not.
If it's possible to refactor the code to not use blocking calls, that
should be done. Since it's really hard to get rid of the blocking calls in
processing methods, it leaves the only choice of switching to use
`.forEachInSnapshot` instead of `.forEach`.
Makes sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
