codelipenghui commented on a change in pull request #9738:
URL: https://github.com/apache/pulsar/pull/9738#discussion_r585686991
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -957,8 +957,9 @@ public NamespaceService getNamespaceService() {
return functionWorkerService;
}
- public WorkerService getWorkerService() {
- return functionWorkerService.orElse(null);
+ public WorkerService getWorkerService() throws
UnsupportedOperationException {
+ return functionWorkerService.orElseThrow(() -> new
UnsupportedOperationException("Pulsar Function Worker is not " +
+ "enabled, probably functionsWorkerEnabled is set to false"));
Review comment:
In my opinion, If throw exception while getWorkerService(), this might
break some other places since it might just want to return a null value. As I
said before if all the places are ok for handling the exception that
getWorkerService() throws, I'm ok. I just worry about introducing some break
changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
