Lanayx edited a comment on issue #9557: URL: https://github.com/apache/pulsar/issues/9557#issuecomment-788991495
Hi, @codelipenghui It seems you've misunderstood the issue :) My concern is that [this line](https://github.com/apache/pulsar/blob/branch-2.6/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1854) will give incorrect result if batched message id passed to the method had been taken from byte array (serialized and deserialized) since bath size is missing in byte representation of batched message id. The repro is the following: 1) Consumer receives the batch of 5 messages, 2) Consumer notes 3d message id 3) Consumer performs seek on 3d messageId - everything works as expected 4) Consumer serializes 3d messageId to byteArray 5) Consumer restores 3d messageId from byteArray 6) Consumer performs seek on restored 3d messageId - the seek logic breaks since batch size is incorrect Rather than storing batch size in the fix I would expect changing this new seek logic so it won't depend on batch size. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
