congbobo184 commented on a change in pull request #9776:
URL: https://github.com/apache/pulsar/pull/9776#discussion_r586188447
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java
##########
@@ -63,11 +61,18 @@
private final ArrayList<CompletableFuture<MessageId>> sendFutureList;
private final ArrayList<CompletableFuture<Void>> ackFutureList;
+ private volatile State state;
+
+ public enum State {
+ OPEN,
+ CLOSE
Review comment:
commit or abort finish, the state will become closed. we don't need to
change the state to committing or aborting, it seem not useful. When we need
committing or aborting sate we can add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
