codelipenghui commented on a change in pull request #9786:
URL: https://github.com/apache/pulsar/pull/9786#discussion_r586913062
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -18,14 +18,6 @@
*/
package org.apache.pulsar.broker.service;
-import static com.google.common.base.Preconditions.checkArgument;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static org.apache.bookkeeper.mledger.util.SafeRun.safeRun;
-import static org.apache.commons.collections.CollectionUtils.isEmpty;
-import static org.apache.commons.lang3.StringUtils.isNotBlank;
-import static
org.apache.pulsar.broker.cache.ConfigurationCacheService.POLICIES;
-import static
org.apache.pulsar.broker.cache.LocalZooKeeperCacheService.LOCAL_POLICIES_ROOT;
-import static org.apache.pulsar.broker.web.PulsarWebResource.joinPath;
Review comment:
Could you please check the import style? Seem this not related to this
fix.
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -798,7 +800,7 @@ public void unloadNamespaceBundlesGracefully() {
});
} else {
return topics.computeIfAbsent(topic, (topicName) -> {
- if (createIfMissing) {
+ if (createIfMissing ||
TopicName.get(topicName).isPartitioned()) {
Review comment:
I think it's not a correct fix. The expected behavior is if the
partitioned non-persistent topic created, then we allow the partitions of the
partitioned non-persistent topic to create automatically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
