Anonymitaet commented on a change in pull request #9779: URL: https://github.com/apache/pulsar/pull/9779#discussion_r587299603
########## File path: site2/docs/reference-configuration.md ########## @@ -129,7 +129,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora |dbStorage_rocksDB_numLevels||-1| |dbStorage_rocksDB_numFilesInLevel0||4| |dbStorage_rocksDB_maxSizeInLevel1MB||256| - +bookieId | If you want to custom bookie ID or use a dynamic network address for the bookie, you can set this option. <br><br>Bookie advertises itself using `bookieId` rather than `BookieSocketAddress` (hostname:port or IP:port).<br><br> `bookieId` is a non empty string that can contain ASCII digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more information about `bookieId`, see [here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/| Review comment: @eolivelli thanks for your comments, I've incorporated, PTAL. This part belongs to the BookKeeper configuration. I've made the following changes based on your comments: 1. `useHostNameAsBookieID` is in the `bookkeeper.conf` file, so I move these lines next to `useHostNameAsBookieID`. 2. I add `If you set `bookieId`, then `useHostNameAsBookieID` does not take effect.` 3. I add `N/A` for the default value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
