jerrypeng commented on pull request #9638:
URL: https://github.com/apache/pulsar/pull/9638#issuecomment-790834459


   Also because this PR:
   
   https://github.com/apache/pulsar/pull/9246/
   
   That separated pulsar-client-admin into two modules pulsar-client-admin and 
pulsar-client-admin-api.  pulsar-cient-admin-api module pulls in a bunch of 
dependencies which doesn't make sense for a "api" module.  The java-instance 
that gets loaded by the root classloader should only contain those few 
interfaces but now contain
   
   ` org.apache.pulsar:pulsar-functions-runtime-all:jar:2.7.0
   [INFO] +- org.apache.pulsar:pulsar-io-core:jar:2.7.0:compile
   [INFO] |  \- (org.apache.pulsar:pulsar-functions-api:jar:2.7.0:compile - 
omitted for duplicate)
   [INFO] +- org.apache.pulsar:pulsar-functions-api:jar:2.7.0:compile
   [INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.25:compile - version managed from 
1.7.30; omitted for duplicate)
   [INFO] |  +- (org.apache.pulsar:pulsar-client-api:jar:2.7.0:compile - 
omitted for duplicate)
   [INFO] |  \- org.apache.pulsar:pulsar-client-admin-api:jar:2.7.0:compile
   [INFO] |     +- org.apache.pulsar:pulsar-common:jar:2.7.0:compile
   [INFO] |     |  +- (org.apache.pulsar:pulsar-client-api:jar:2.7.0:compile - 
omitted for duplicate)
   [INFO] |     |  +- io.swagger:swagger-annotations:jar:1.6.2:compile
   [INFO] |     |  +- (org.slf4j:slf4j-api:jar:1.7.25:compile - version managed 
from 1.7.30; omitted for duplicate)
   [INFO] |     |  +- 
com.fasterxml.jackson.core:jackson-databind:jar:2.11.1:compile (version managed 
from 2.9.9.3)
   [INFO] |     |  |  +- 
com.fasterxml.jackson.core:jackson-annotations:jar:2.11.1:compile
   [INFO] |     |  |  \- 
com.fasterxml.jackson.core:jackson-core:jar:2.11.1:compile (version managed 
from 2.9.9)
   [INFO] |     |  +- com.google.guava:guava:jar:30.1-jre:compile (version 
managed from 29.0-android)
   [INFO] |     |  |  +- com.google.guava:failureaccess:jar:1.0.1:compile
   [INFO] |     |  |  +- 
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
   [INFO] |     |  |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
   [INFO] |     |  |  +- org.checkerframework:checker-qual:jar:3.5.0:compile
   [INFO] |     |  |  +- 
com.google.errorprone:error_prone_annotations:jar:2.3.4:compile
   [INFO] |     |  |  \- com.google.j2objc:j2objc-annotations:jar:1.3:compile
   [INFO] |     |  +- io.netty:netty-handler:jar:4.1.51.Final:compile
   [INFO] |     |  |  +- io.netty:netty-common:jar:4.1.51.Final:compile
   [INFO] |     |  |  +- io.netty:netty-resolver:jar:4.1.51.Final:compile
   [INFO] |     |  |  |  \- (io.netty:netty-common:jar:4.1.51.Final:compile - 
omitted for duplicate)
   [INFO] |     |  |  +- io.netty:netty-buffer:jar:4.1.51.Final:compile
   [INFO] |     |  |  |  \- (io.netty:netty-common:jar:4.1.51.Final:compile - 
omitted for duplicate)
   [INFO] |     |  |  +- io.netty:netty-transport:jar:4.1.51.Final:compile
   [INFO] |     |  |  |  +- (io.netty:netty-common:jar:4.1.51.Final:compile - 
omitted for duplicate)
   [INFO] |     |  |  |  +- (io.netty:netty-buffer:jar:4.1.51.Final:compile - 
omitted for duplicate)
   ...`
   
   This is also a problem.  @lhotari this is why the tests pass for the 
connectors even though dependencies are not packaged explicitly.  @sijie that 
PR has become very problematic for many reasons now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to