eolivelli commented on a change in pull request #9815:
URL: https://github.com/apache/pulsar/pull/9815#discussion_r588197844
##########
File path: pom.xml
##########
@@ -1385,6 +1402,52 @@ flexible messaging model and an intuitive client
API.</description>
<!-- helm files -->
<exclude>**/.helmignore</exclude>
<exclude>**/_helpers.tpl</exclude>
+
+ <!-- project ignored files -->
+ <exclude>.git/**</exclude>
Review comment:
this is automatic
##########
File path: pom.xml
##########
@@ -1302,6 +1302,23 @@ flexible messaging model and an intuitive client
API.</description>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
+ <includes>
Review comment:
we do we need to explicitly select files to include ?
isn't it better to let the plugin scan the whole directory ?
we could skip files without noticing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
