merlimat commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r589837135
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
##########
@@ -18,6 +18,7 @@
*/
package org.apache.pulsar.client.api;
+import io.netty.util.Timer;
Review comment:
> Or we can pass the Timer through the PulsarClientImpl constructor?
Yes, we can add it to the constructor (or leave it null to get it created
internally). It's ok to do so because `PulsarClientImpl` is not part of public
API (but can be used by pulsar proxy).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
