lhotari commented on pull request #9638:
URL: https://github.com/apache/pulsar/pull/9638#issuecomment-793741618
> I liked the motivation. I am also good with making `pulsar-io-core` as
`provided` dependency. However, I see you also turn some of the dependencies
shared between the Pulsar runtime and connector implementation to the
`provided` scope. I am not comfortable with that change. Because even they are
the same dependency, they will be loaded via different class loaders. I am not
sure turning them into `provided` will not break any connector implementation.
@sijie Thank you for reviewing. Yes you are right that it's not fine to
change the dependencies. I verified some details and wrote a report about that
in the previous comment. It's indeed that #9246 (open issue #9640) is causing
the issues and it also pollutes the classes that are available in the current
parent classloader of the function user code classloader.
It seems that it would be fine to make the dependencies `provided` which are
part of pulsar-functions/runtime-all/pom.xml since that creates the
java-instance.jar . The size of these dependencies is very low (in 2.7.0, it's
about 2MB) so it wouldn't save much in the overall size which was the goal of
this PR.
Since that's the case, I'll close this PR.
I hope #9640 gets addressed asap since I think it could be considered as a
blocker for the 2.8.0 release.
It seems that there's a PR #9842 in WIP state currently. Great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
