merlimat commented on a change in pull request #9842:
URL: https://github.com/apache/pulsar/pull/9842#discussion_r590763057
##########
File path: pulsar-client-admin-api/pom.xml
##########
@@ -35,20 +35,54 @@
<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
- <artifactId>pulsar-common</artifactId>
+ <artifactId>pulsar-client-api</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>pulsar-client-original</artifactId>
- <version>${project.parent.version}</version>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <scope>provided</scope>
Review comment:
This API package shouldn't depend on anything more than
`pulsar-client-api`.
Having the dependencies marked as "provided" doesn't really fix the issue
because the implementation will still be using them. We should instead make
sure that the POJOs are not using any other dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
