lhotari edited a comment on pull request #9850: URL: https://github.com/apache/pulsar/pull/9850#issuecomment-795204768
> If we want to solve the problem of visibility, we can set all internal objects to volatile, but it doesn't make much sense. Now all the attributes in Policies are objects, and many of them are directly assigned. Does this kind of short-lived invisible have a great impact on us? Yes, it's really necessary to achieve "safe publication" when new objects are shared to other threads. Otherwise, thread safety issues won't be fixed. Using "volatile" isn't necessary for achieving "safe publication". Since the description of this PR says "Fixes #9711", I think that should be removed from the description or the remaining thread safety issues should be fixed as part of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
