congbobo184 commented on a change in pull request #9841: URL: https://github.com/apache/pulsar/pull/9841#discussion_r591462155
########## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeRowDecoderFactory.java ########## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.sql.presto.decoder.protobufnative; + +import static com.google.common.collect.ImmutableList.toImmutableList; +import static io.prestosql.spi.StandardErrorCode.NOT_SUPPORTED; +import static io.prestosql.spi.type.VarcharType.createUnboundedVarcharType; +import static java.util.stream.Collectors.toList; + +import com.google.common.collect.ImmutableList; +import com.google.protobuf.Descriptors; +import io.airlift.log.Logger; +import io.prestosql.decoder.DecoderColumnHandle; +import io.prestosql.spi.PrestoException; +import io.prestosql.spi.connector.ColumnMetadata; +import io.prestosql.spi.type.ArrayType; +import io.prestosql.spi.type.BigintType; +import io.prestosql.spi.type.BooleanType; +import io.prestosql.spi.type.DoubleType; +import io.prestosql.spi.type.IntegerType; +import io.prestosql.spi.type.RealType; +import io.prestosql.spi.type.RowType; +import io.prestosql.spi.type.StandardTypes; +import io.prestosql.spi.type.Type; +import io.prestosql.spi.type.TypeManager; +import io.prestosql.spi.type.TypeSignature; +import io.prestosql.spi.type.TypeSignatureParameter; +import io.prestosql.spi.type.VarbinaryType; +import java.util.List; +import java.util.Optional; +import java.util.Set; +import org.apache.commons.lang3.StringUtils; +import org.apache.pulsar.client.impl.schema.generic.GenericProtobufNativeSchema; +import org.apache.pulsar.common.naming.TopicName; +import org.apache.pulsar.common.schema.SchemaInfo; +import org.apache.pulsar.sql.presto.PulsarColumnHandle; +import org.apache.pulsar.sql.presto.PulsarColumnMetadata; +import org.apache.pulsar.sql.presto.PulsarRowDecoder; +import org.apache.pulsar.sql.presto.PulsarRowDecoderFactory; + +/** + * PulsarRowDecoderFactory for {@link org.apache.pulsar.common.schema.SchemaType#PROTOBUF_NATIVE}. + */ +public class PulsarProtobufNativeRowDecoderFactory implements PulsarRowDecoderFactory { + + private TypeManager typeManager; + + public PulsarProtobufNativeRowDecoderFactory(TypeManager typeManager) { + this.typeManager = typeManager; + } + + @Override + public PulsarRowDecoder createRowDecoder(TopicName topicName, SchemaInfo schemaInfo, + Set<DecoderColumnHandle> columns) { + return new PulsarProtobufNativeRowDecoder((GenericProtobufNativeSchema) GenericProtobufNativeSchema.of(schemaInfo), columns); + } + + @Override + public List<ColumnMetadata> extractColumnMetadata(TopicName topicName, SchemaInfo schemaInfo, + PulsarColumnHandle.HandleKeyValueType handleKeyValueType) { + List<ColumnMetadata> columnMetadata; + String schemaJson = new String(schemaInfo.getSchema()); + if (StringUtils.isBlank(schemaJson)) { + throw new PrestoException(NOT_SUPPORTED, "Topic " + + topicName.toString() + " does not have a valid schema"); + } + Descriptors.Descriptor schema; + try { + schema = + ((GenericProtobufNativeSchema) GenericProtobufNativeSchema.of(schemaInfo)).getProtobufNativeSchema(); + } catch (Exception ex) { + log.error(ex); + throw new PrestoException(NOT_SUPPORTED, "Topic " + + topicName.toString() + " does not have a valid schema"); + } + + //Protobuf have not yet supported Cyclic Objects. + columnMetadata = schema.getFields().stream() + .map(field -> + new PulsarColumnMetadata(PulsarColumnMetadata.getColumnName(handleKeyValueType, field.getName()), + parseProtobufPrestoType(field), field.getType().toString(), null, false, false, + handleKeyValueType, new PulsarColumnMetadata.DecoderExtraInfo(field.getName(), + null, null)) + + ).collect(toList()); + + return columnMetadata; + } + + private Type parseProtobufPrestoType(Descriptors.FieldDescriptor field) { + //parse by proto JavaType + Descriptors.FieldDescriptor.JavaType type = field.getJavaType(); + Type dataType; + switch (type) { + case BOOLEAN: + dataType = BooleanType.BOOLEAN; + break; + case BYTE_STRING: + dataType = VarbinaryType.VARBINARY; + break; + case DOUBLE: + dataType = DoubleType.DOUBLE; + break; + case ENUM: + case STRING: + dataType = createUnboundedVarcharType(); + break; + case FLOAT: + dataType = RealType.REAL; + break; + case INT: + dataType = IntegerType.INTEGER; + break; + case LONG: + dataType = BigintType.BIGINT; + break; + case MESSAGE: + Descriptors.Descriptor msg = field.getMessageType(); + if (field.isMapField()) { + //map + TypeSignature keyType = parseProtobufPrestoType(msg.findFieldByName("key")).getTypeSignature(); + TypeSignature valueType = parseProtobufPrestoType(msg.findFieldByName("value")).getTypeSignature(); + return typeManager.getParameterizedType(StandardTypes.MAP, + ImmutableList.of(TypeSignatureParameter.typeParameter(keyType), + TypeSignatureParameter.typeParameter(valueType))); + } else { + //row + dataType = RowType.from(msg.getFields().stream() + .map(rowField -> new RowType.Field(Optional.of(rowField.getName()), + parseProtobufPrestoType(rowField))) + .collect(toImmutableList())); + } + break; + default: + throw new RuntimeException("Unknown type: " + type.toString() + " for FieldDescriptor: " + field.getName()); + } + //list + if (field.isRepeated() && !field.isMapField()) { + dataType = new ArrayType(dataType); + } Review comment: I think this logic should move to switch block. ########## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/protobufnative/PulsarProtobufNativeColumnDecoder.java ########## @@ -0,0 +1,386 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.sql.presto.decoder.protobufnative; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkState; +import static io.airlift.slice.Slices.utf8Slice; +import static io.prestosql.decoder.DecoderErrorCode.DECODER_CONVERSION_NOT_SUPPORTED; +import static io.prestosql.spi.StandardErrorCode.GENERIC_USER_ERROR; +import static io.prestosql.spi.type.Varchars.truncateToLength; +import static java.lang.Float.floatToIntBits; +import static java.lang.String.format; +import static java.util.Objects.requireNonNull; + +import com.google.common.base.Splitter; +import com.google.common.collect.ImmutableSet; +import com.google.protobuf.ByteString; +import com.google.protobuf.DynamicMessage; +import com.google.protobuf.EnumValue; +import io.airlift.slice.Slice; +import io.airlift.slice.Slices; +import io.prestosql.decoder.DecoderColumnHandle; +import io.prestosql.decoder.FieldValueProvider; +import io.prestosql.spi.PrestoException; +import io.prestosql.spi.block.Block; +import io.prestosql.spi.block.BlockBuilder; +import io.prestosql.spi.type.ArrayType; +import io.prestosql.spi.type.BigintType; +import io.prestosql.spi.type.BooleanType; +import io.prestosql.spi.type.DoubleType; +import io.prestosql.spi.type.IntegerType; +import io.prestosql.spi.type.MapType; +import io.prestosql.spi.type.RealType; +import io.prestosql.spi.type.RowType; +import io.prestosql.spi.type.RowType.Field; +import io.prestosql.spi.type.SmallintType; +import io.prestosql.spi.type.TimestampType; +import io.prestosql.spi.type.TinyintType; +import io.prestosql.spi.type.Type; +import io.prestosql.spi.type.VarbinaryType; +import io.prestosql.spi.type.VarcharType; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** + * Pulsar {@link org.apache.pulsar.common.schema.SchemaType#PROTOBUF_NATIVE} ColumnDecoder. + */ +public class PulsarProtobufNativeColumnDecoder { + private static final Set<Type> SUPPORTED_PRIMITIVE_TYPES = ImmutableSet.of( + BooleanType.BOOLEAN, + IntegerType.INTEGER, + BigintType.BIGINT, + RealType.REAL, + DoubleType.DOUBLE, + VarbinaryType.VARBINARY); + + private final Type columnType; + private final String columnMapping; + private final String columnName; + + public PulsarProtobufNativeColumnDecoder(DecoderColumnHandle columnHandle) { + try { + requireNonNull(columnHandle, "columnHandle is null"); + this.columnType = columnHandle.getType(); + this.columnMapping = columnHandle.getMapping(); + this.columnName = columnHandle.getName(); + checkArgument(!columnHandle.isInternal(), + "unexpected internal column '%s'", columnName); + checkArgument(columnHandle.getFormatHint() == null, + "unexpected format hint '%s' defined for column '%s'", columnHandle.getFormatHint(), columnName); + checkArgument(columnHandle.getDataFormat() == null, + "unexpected data format '%s' defined for column '%s'", columnHandle.getDataFormat(), columnName); + checkArgument(columnHandle.getMapping() != null, + "mapping not defined for column '%s'", columnName); + checkArgument(isSupportedType(columnType), + "Unsupported column type '%s' for column '%s'", columnType, columnName); + } catch (IllegalArgumentException e) { + throw new PrestoException(GENERIC_USER_ERROR, e); + } + } + + private static boolean isSupportedType(Type type) { + if (isSupportedPrimitive(type)) { + return true; + } + + if (type instanceof ArrayType) { + checkArgument(type.getTypeParameters().size() == 1, + "expecting exactly one type parameter for array"); + return isSupportedType(type.getTypeParameters().get(0)); + } + + if (type instanceof MapType) { + List<Type> typeParameters = type.getTypeParameters(); + checkArgument(typeParameters.size() == 2, + "expecting exactly two type parameters for map"); + return isSupportedType(typeParameters.get(1)) && isSupportedType(typeParameters.get(0)); + } + + if (type instanceof RowType) { + for (Type fieldType : type.getTypeParameters()) { + if (!isSupportedType(fieldType)) { + return false; + } + } + return true; + } + return false; + } + + private static boolean isSupportedPrimitive(Type type) { + return type instanceof VarcharType || SUPPORTED_PRIMITIVE_TYPES.contains(type); + } + + public FieldValueProvider decodeField(DynamicMessage dynamicMessage) { + Object columnValue = locateNode(dynamicMessage, columnMapping); + return new ObjectValueProvider(columnValue, columnType, columnName); + } + + private static Object locateNode(DynamicMessage element, String columnMapping) { + Object value = element; + for (String pathElement : Splitter.on('/').omitEmptyStrings().split(columnMapping)) { + if (value == null) { + return null; + } + value = ((DynamicMessage) value).getField(((DynamicMessage) value).getDescriptorForType().findFieldByName(pathElement)); + } + return value; + } + + private static class ObjectValueProvider + extends FieldValueProvider { + private final Object value; + private final Type columnType; + private final String columnName; + + public ObjectValueProvider(Object value, Type columnType, String columnName) { + this.value = value; + this.columnType = columnType; + this.columnName = columnName; + } + + @Override + public boolean isNull() { + return value == null; + } + + @Override + public double getDouble() { + if (value instanceof Double || value instanceof Float) { + return ((Number) value).doubleValue(); + } + throw new PrestoException(DECODER_CONVERSION_NOT_SUPPORTED, + format("cannot decode object of '%s' as '%s' for column '%s'", + value.getClass(), columnType, columnName)); + } + + @Override + public boolean getBoolean() { + if (value instanceof Boolean) { + return (Boolean) value; + } + throw new PrestoException(DECODER_CONVERSION_NOT_SUPPORTED, + format("cannot decode object of '%s' as '%s' for column '%s'", + value.getClass(), columnType, columnName)); + } + + @Override + public long getLong() { + if (value instanceof Long || value instanceof Integer) { + return ((Number) value).longValue(); + } + + if (columnType instanceof RealType) { + return floatToIntBits((Float) value); + } + + throw new PrestoException(DECODER_CONVERSION_NOT_SUPPORTED, + format("cannot decode object of '%s' as '%s' for column '%s'", + value.getClass(), columnType, columnName)); + } + + @Override + public Slice getSlice() { + return PulsarProtobufNativeColumnDecoder.getSlice(value, columnType, columnName); + } + + @Override + public Block getBlock() { + return serializeObject(null, value, columnType, columnName); + } + } + + private static Slice getSlice(Object value, Type type, String columnName) { + + if (value instanceof ByteString) { + return Slices.wrappedBuffer(((ByteString) value).toByteArray()); + } else if (value instanceof EnumValue) { //enum + return truncateToLength(utf8Slice(((EnumValue) value).getName()), type); + } else if (value instanceof byte[]) { + return Slices.wrappedBuffer((byte[]) value); + } + + if (type instanceof VarcharType) { + return truncateToLength(utf8Slice(value.toString()), type); + } + + throw new PrestoException(DECODER_CONVERSION_NOT_SUPPORTED, + format("cannot decode object of '%s' as '%s' for column '%s'", + value.getClass(), type, columnName)); + } + + private static Block serializeObject(BlockBuilder builder, Object value, Type type, String columnName) { + if (type instanceof ArrayType) { + return serializeList(builder, value, type, columnName); + } + if (type instanceof MapType) { + return serializeMap(builder, value, type, columnName); + } + if (type instanceof RowType) { + return serializeRow(builder, value, type, columnName); + } + serializePrimitive(builder, value, type, columnName); + return null; + } + + private static Block serializeList(BlockBuilder parentBlockBuilder, Object value, Type type, String columnName) { + if (value == null) { + checkState(parentBlockBuilder != null, "parentBlockBuilder is null"); + parentBlockBuilder.appendNull(); + return null; + } + List<?> list = (List<?>) value; + List<Type> typeParameters = type.getTypeParameters(); + Type elementType = typeParameters.get(0); + + BlockBuilder blockBuilder = elementType.createBlockBuilder(null, list.size()); + for (Object element : list) { + serializeObject(blockBuilder, element, elementType, columnName); + } + if (parentBlockBuilder != null) { + type.writeObject(parentBlockBuilder, blockBuilder.build()); + return null; + } + return blockBuilder.build(); + } + + private static void serializePrimitive(BlockBuilder blockBuilder, Object value, Type type, String columnName) { + requireNonNull(blockBuilder, "parent blockBuilder is null"); + + if (value == null) { + blockBuilder.appendNull(); + return; + } + + if (type instanceof BooleanType) { + type.writeBoolean(blockBuilder, (Boolean) value); + return; + } + + if ((value instanceof Integer || value instanceof Long) + && (type instanceof BigintType || type instanceof IntegerType + || type instanceof SmallintType || type instanceof TinyintType)) { + type.writeLong(blockBuilder, ((Number) value).longValue()); + return; + } + + if (type instanceof DoubleType) { + type.writeDouble(blockBuilder, (Double) value); + return; + } + + if (type instanceof RealType) { + type.writeLong(blockBuilder, floatToIntBits((Float) value)); + return; + } + + if (type instanceof VarcharType || type instanceof VarbinaryType) { + type.writeSlice(blockBuilder, getSlice(value, type, columnName)); + return; + } + + if (type instanceof TimestampType) { + type.writeLong(blockBuilder, (Long) value); + return; Review comment: some static code are very similar to ```PulsarAvroColumnDecoder```, It seems that some should be deleted or unified in to one method ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
