michaeljmarshall commented on pull request #8739: URL: https://github.com/apache/pulsar/pull/8739#issuecomment-796425605
@sijie and @gaoran10 - I just ran into the class loader leak that this PR corrects. However, I notice that we switch from `offloadPolicies.getOffloadersDirectory()` to `config.getOffloadersDirectory()` for the first argument of the `OffloaderUtils.searchForOffloaders` method. That argument is the directory to search for the `.nar` files. As such, the `offloaderDirectory` won't be able to be overriden at the namespace level. I opened up #9878 to restore the ability to overload the directory. Please take a look at the PR, if you have time. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
