codelipenghui commented on a change in pull request #9877:
URL: https://github.com/apache/pulsar/pull/9877#discussion_r592049958
##########
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -90,6 +120,29 @@
*/
CompletableFuture<List<String>> getListAsync(String namespace);
+ /**
+ * Get the list of topics under a namespace asynchronously.
+ * <p/>
+ * Response example:
+ *
+ * <pre>
+ * <code>["topic://my-tenant/my-namespace/topic-1",
+ * "topic://my-tenant/my-namespace/topic-2"]</code>
+ * </pre>
+ *
+ * @param namespace
+ * Namespace name
+ *
+ * @param mode
+ * Get topic mode
+ * use {@link GetTopicsMode#PERSISTENT} to get persistent topics
+ * use {@link GetTopicsMode#NON_PERSISTENT} to get
non-persistent topics
Review comment:
Why non-persistent topics will always return empty? I'm not getting the
key point here, currently the list topics operation combine the persistent
topics and non-persistent topic, I also add test for cover this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
