eolivelli commented on pull request #9900:
URL: https://github.com/apache/pulsar/pull/9900#issuecomment-798954139


   IMHO we should fix MetadataCacheImpl, the signature and the semantics of the 
method is to be documented.
   A cache that lets you modify internal state is very likely to cause much 
problems in the future.
   If there will be other implementations then we must ensure that they don't 
have this problem.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to