dlg99 edited a comment on pull request #9825: URL: https://github.com/apache/pulsar/pull/9825#issuecomment-799608835
@sijie The goal is using Kafka Connect Sink in Pusar Sink. There is already Pulsar's KafkaBytesSink (in pulsar-io/kafka/ module) that writes data to kafka. Instead of adding another Sink and later dealing with potentially duplicate changes related to i.e. Schema, the change wraps Kafka Connect Sink into the kafka producer API and makes existing Pulsar's Sink use it. Kafka Connect Sink accepts (through the SinkRecord) and uses Schemas to send data to the third-party system. there is no need to serialize data before Schemas also will be used after @eolivelli's changes unblock implementation of `Sink<Object>`. the nar module split does not affect anything functionally but - avoids building nar file when I simply want build module / run tests (mvn clean install) - simplifies dependencies definition in added profile. There is a default profile (as existing) and the one that specifies Kafka Connect module to include into nar. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
