michaeljmarshall commented on pull request #9878:
URL: https://github.com/apache/pulsar/pull/9878#issuecomment-799972743


   In putting together the test, I noticed that the implementation would be 
cleaner with new class and test just that class, so I refactored the original 
change.
   
   @sijie - let me know what you think about this test. I had wanted to include 
the following:
   
   ```java
           // Should only be called a single time because of the caching
           PowerMockito.verifyStatic(OffloaderUtils.class, Mockito.times(1));
   ```
   
   but it failed, and I'm not quite sure why. If you think it is important to 
include a test on the idempotency of loading an offloaders class, let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to