aahmed-se commented on a change in pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948#discussion_r596473985
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -99,7 +100,8 @@
@Override
public void close() throws IOException {
- // noop
+ expiredTokenMetrics.clear();
+ expiringTokenMinutesMetrics.clear();
Review comment:
Well the static metrics cause some of the tests to flake, this fixed the
test issues, for running services I think clearing static metrics during close
makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
