eolivelli commented on a change in pull request #9967:
URL: https://github.com/apache/pulsar/pull/9967#discussion_r597448232
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/discovery/service/web/DiscoveryServiceWebTest.java
##########
@@ -56,6 +56,9 @@
public class DiscoveryServiceWebTest extends ProducerConsumerBase {
private final Client client = ClientBuilder.newClient(new
ClientConfig().register(LoggingFeature.class));
+ // DiscoveryServiceServlet gets initialized by a server and this map will
help to retrieve ZK while mocking
+ // DiscoveryServiceServlet
+ private static final Map<String, MetadataStoreExtended>
metadataStoreInstanceCache = Maps.newConcurrentMap();
Review comment:
it looks like we are not clearing this map at the end of the test.
we will leak MetadataStoreExtended instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
