lhotari opened a new pull request #10007: URL: https://github.com/apache/pulsar/pull/10007
### Motivation The current solution for "shading" AsyncHttpClient's properties file is invalid and prone to errors. The solution breaks when the classloading order changes. There is some change in classloading order when upgrading to Apache Parent POM version 23 and this causes the shading tests to fail. The root cause of this issue is the invalid shading solution for AsyncHttpClient. When the classloading order changes, the shaded class picks up ahc-default.properties from this file: https://github.com/apache/pulsar/blob/430f1f34d353410bb96cddce505b35240f0f3794/pulsar-client-admin/src/main/resources/org/asynchttpclient/config/ahc-default.properties . This file hasn't been properly shaded in the shaded pulsar-client-admin.jar . ### Modifications - remove all ahc.properties and ahc-default.properties files from the Pulsar code base since they have been added to the code base as an attempt to fix AsyncHttpClient shading. - extract ahc-default.properties file and modify the file to add the shaded package prefix to the classnames in the properties file - handle the shading of AsyncHttpClient's ahc-default.properties file in all libraries that contain the shaded AsyncHttpClient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
