[GitHub] [pulsar] zymap commented on a change in pull request #10015: Support set property on a namespace.

[GitBox]

zymap commented on a change in pull request #10015:
URL: https://github.com/apache/pulsar/pull/10015#discussion_r599587564



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2546,6 +2546,45 @@ protected void internalSetMaxTopicsPerNamespace(Integer 
maxTopicsPerNamespace) {
         internalSetPolicies("max_topics_per_namespace", maxTopicsPerNamespace);
    }
 
+   protected void internalSetProperty(String key, String value) {
+       validatePoliciesReadOnlyAccess();
+       try {
+           final String path = path(POLICIES, namespaceName.toString());
+           updatePolicies(path, (policies) -> {
+               policies.properties.put(key, value);

Review comment:
       Do we need to provide an option for overwriting the existing key?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org