eolivelli commented on a change in pull request #10025:
URL: https://github.com/apache/pulsar/pull/10025#discussion_r600193125
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java
##########
@@ -81,7 +81,8 @@
*
* <p>Only messages received from the consumer will have a message id
assigned.
*
- * @return the message id null if this message was not received by this
client instance
+ * @return the message id
+ * @throws NullPointerException if the message is null (message was not
received by this client instance)
Review comment:
In my opinion is it unlikely that a Java program catches an NPE in order
to detect this case.
We can remove the null check and release the change in 2.8.0.
I am pretty sure that no one will notice this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
