codelipenghui commented on a change in pull request #10012:
URL: https://github.com/apache/pulsar/pull/10012#discussion_r600317909
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -305,6 +305,13 @@
)
private long topicLoadTimeoutSeconds = 60;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ required = false,
+ doc = "defined your own decryption interface"
+ )
+ private String decryptionInterface;
Review comment:
Users need to provide a Decryption implementation themself, But I did
not find any jar load implementation. In my opinion, users need to private a
location that where to find the jar? Otherwise, users need to copy jar under
the classpath.
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -305,6 +305,13 @@
)
private long topicLoadTimeoutSeconds = 60;
+ @FieldContext(
+ category = CATEGORY_SERVER,
Review comment:
Should be `CATEGORY_AUTHENTICATION` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
