codelipenghui commented on a change in pull request #10008:
URL: https://github.com/apache/pulsar/pull/10008#discussion_r600329510
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -680,6 +680,26 @@
+ " non-backlog consumers as well.")
private boolean dispatchThrottlingOnNonBacklogConsumerEnabled = false;
+ @FieldContext(
+ category = CATEGORY_POLICIES,
+ doc = "Default policy for publishing usage reports to system topic
is disabled."
+ + "This enables publishing of usage reports"
+ )
+ private boolean resourceUsagePublishToTopic = false;
+
+ @FieldContext(
+ category = CATEGORY_POLICIES,
+ doc = "Topic to publish usage reports to if
resourceUsagePublishToTopic is enabled."
+ )
+ private String resourceUsagePublishTopicName =
"non-persistent://pulsar/system/resource-usage";
Review comment:
This one should be an internal topic, I think we don't need to expose it
to users.
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -680,6 +680,26 @@
+ " non-backlog consumers as well.")
private boolean dispatchThrottlingOnNonBacklogConsumerEnabled = false;
+ @FieldContext(
+ category = CATEGORY_POLICIES,
+ doc = "Default policy for publishing usage reports to system topic
is disabled."
+ + "This enables publishing of usage reports"
+ )
+ private boolean resourceUsagePublishToTopic = false;
Review comment:
Is it better to expose namespaceResourceLimiterEnabled or
tenantResourceLimiterEnabled to users? the `resourceUsagePublishToTopic` is an
internal mechanism, expose it to users is need the user to understand the
details of his work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
