gmethvin commented on pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#issuecomment-806260958
@315157973 @eolivelli I updated to delegate to the static method. I think I understand what you're saying now. Your change to `BatchMessageIdImpl#hashCode` works if you keep the existing code in `MessageIdImpl#hashCode`. The problem is now you have the logic in two different places, which I'd like to avoid, since that's probably why we ended up with this inconsistency to begin with. Having the logic in one place makes the code a lot easier to understand and reduces the chance of future breakage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
