lhotari commented on a change in pull request #10057: URL: https://github.com/apache/pulsar/pull/10057#discussion_r603826955
########## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/GenericObject.java ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.api.schema; + +import org.apache.pulsar.common.schema.SchemaType; + +/** + * This is an abstraction over the logical value that is store into a Message. + * Pulsar decodes the payload of the Message using the Schema that is configured for the topic. + */ +public interface GenericObject { + + /** + * Return the schema tyoe. + * + * @return the schema type + * @throws UnsupportedOperationException if this feature is not implemented + * @see SchemaType#BYTES when the topic has no schema information + * @see SchemaType#STRING + * @see SchemaType#AVRO + * @see SchemaType#PROTOBUF_NATIVE + * @see SchemaType#JSON + */ + SchemaType getSchemaType(); + + /** + * Return the internal native representation of the Object, + * like a AVRO GenericRecord, a String or a byte[]. + * + * @return the decoded object + * @throws UnsupportedOperationException if the operation is not supported + */ + Object getNativeObject(); Review comment: @sijie I checked the discussion that @eolivelli [is referring to](https://github.com/apache/pulsar/pull/9614#discussion_r589185278). I believe it's a common solution to have API methods such as `<T> T getNativeObject(Class<T> objectType)` . For example, Jackson uses a similar solution, there is [`public <T> T readValue(String content, Class<T> valueType)` method in `ObjectMapper`](https://github.com/FasterXML/jackson-databind/blob/28862205ea6d17ae371a057cea07280ccea6416e/src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java#L1545). Isn't this also the style of Flink Java APIs? (/cc @addisonj) WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
