merlimat commented on a change in pull request #10091:
URL: https://github.com/apache/pulsar/pull/10091#discussion_r604335765
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -46,9 +47,11 @@
private String serviceUrl;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private transient ServiceUrlProvider serviceUrlProvider;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private Authentication authentication;
Review comment:
This seems to be more a problem in the implementation of
`Authentication` interface. If we ignore it here, we could have objects with
different auth types or credentials that appear to be equals.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -46,9 +47,11 @@
private String serviceUrl;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
Review comment:
Same, the implementations of `ServiceUrlProvider` should ensure a
meaningful "equals()` methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
