michaeljmarshall opened a new pull request #10159: URL: https://github.com/apache/pulsar/pull/10159
While investigating https://github.com/apache/pulsar/issues/9916, I noticed that the `deadLetterProducer` is never closed, which could lead to a leak if enough consumers are configured to deliver DLQ messages. This change does not fix the issue raised here: https://github.com/apache/pulsar/issues/9916. ### Motivation The `deadLetterProducer` should be closed when closing consumer tasks. ### Modifications Added an asynchronous close to the `deadLetterProducer`. ### Alternative Implementations The close could be synchronous, but the method, `closeConsumerTasks`, is void and contains other methods that asynchronously close resources, so I am matching that pattern. I'm happy to change the implementation if others think we want to enforce some type of ordering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
