codelipenghui commented on a change in pull request #10168:
URL: https://github.com/apache/pulsar/pull/10168#discussion_r611290115
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -238,6 +238,9 @@
+ " affecting the accuracy of the delivery time compared to the
scheduled time. Default is 1 second.")
private long delayedDeliveryTickTimeMillis = 1000;
+ @FieldContext(category = CATEGORY_SERVER, doc = "HashedWheelTimer duration
tick time for when retrying on delayed delivery")
+ private long delayedDeliveryTickDurationMillis = 1000;
Review comment:
I know this PR is separating the configuration. I mean the tick time of
the HashedWheelTimer also affects accuracy right? If the
`delayedDeliveryTickTimeMillis` is 5ms and the `delayedDeliveryTickTimeMillis`
is 1000ms, what kind of accuracy guarantee can we get?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
