codelipenghui commented on a change in pull request #10182:
URL: https://github.com/apache/pulsar/pull/10182#discussion_r611290690
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1777,7 +1778,16 @@ protected void handleNewTxn(CommandNewTxn command) {
log.debug("Receive new txn request {} to transaction meta store {}
from {}.",
requestId, tcId, remoteAddress);
}
-
service.pulsar().getTransactionMetadataStoreService().newTransaction(tcId,
command.getTxnTtlSeconds())
+ TransactionMetadataStoreService transactionMetadataStoreService =
+ service.pulsar().getTransactionMetadataStoreService();
+ if (transactionMetadataStoreService == null) {
+ ServiceUnitNotReadyException ex =
Review comment:
We already have `NotAllowedError` in the PulsarApi.proto. We can add an
exception on the broker side, but don't need to introduce a new error type in
the PulsarApi.proto?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
