lhotari commented on pull request #10148:
URL: https://github.com/apache/pulsar/pull/10148#issuecomment-818499916


   > Sorry @lhotari, I want to check the test state of the tests under the 
quarantine group. But I'm not sure how to check them, Could you please point me 
how can I find the failed tests in the quarantine group for this PR?
   
   @codelipenghui  The quarantined test reporting isn't fully working, but it's 
possible to navigate to the logs. Here are the quarantined test failures as 
part of "CI - Unit - Brokers - Other / unit-tests" check: 
https://github.com/apache/pulsar/runs/2327040599?check_suite_focus=true#step:8:133
   
   I know that it would be easier to see the results if it was a separate build 
job. That would add more overhead to our builds and I'd like to avoid that 
since the resource consumption is already really high for our builds.
   
   It seems that the intended reporting solution broke when I moved 
ReplicatorTests to run separately from other Quarantined tests. There are a few 
reasons why I had to do this, mainly because there are so many resource 
leakages that are fixed in PRs #10192 , #10195 , #10196 , #10197, #10198 and 
#10199 . I'd like to propose that we get these PRs merged and I can improve the 
quarantined test reporting after that. @codelipenghui Are you fine with that?
   
   It should always be a blocker issue to fix quarantined tests. Therefore the 
need for good reporting might not be so relevant if fixing quarantined tests is 
taken seriously. 
   
   Some of the problems with quarantined tests will get resolved after the PRs 
to fix resource leakages have been merged. For example, the stability of 
ReplicatorTests will improve significantly and it should be possible to move 
the test out of the quarantine group. There are 1 or 2 flaky test methods which 
need slight fixes, but the root cause has been the resource leaks and 
asynchronous shutdown of broker instances in tests (fixed by #10199).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to