michaeljmarshall commented on a change in pull request #10208:
URL: https://github.com/apache/pulsar/pull/10208#discussion_r612586794



##########
File path: 
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -171,7 +172,7 @@ public RuntimeEnv convert(String value) {
     protected String secretsProviderClassName;
     @Parameter(names = "--secretsProviderConfig", description = "Whats the 
config for the secrets provider", hidden = true)
     protected String secretsProviderConfig;
-    @Parameter(names = "--metricsPortStart", description = "The starting port 
range for metrics server", hidden = true)
+    @Parameter(names = "--metricsPortStart", description = "The starting port 
range for metrics server. When running instances as threads, one metrics server 
is used to host the stats for all instances.", hidden = true)

Review comment:
       Thanks for that explanation. I hadn't realized both options were 
possible. Makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to