lhotari commented on pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#issuecomment-821048730
> The approach LGTM. Just a couple of questions on the await termination @merlimat Thank you for your review and good points about await termination. Please ignore some of the replies I made since I didn't look at the full context of the code when replying. I revisited the code after another check at your review comments. I have rewritten the solution to use `.awaitTermination` and replaced the previous solution that used a ScheduledExecutorService. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
