eolivelli commented on a change in pull request #10248:
URL: https://github.com/apache/pulsar/pull/10248#discussion_r615236917
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/PulsarGenericObjectSinkTest.java
##########
@@ -97,8 +98,10 @@ public void testGenericObjectSink() throws Exception {
new SinkSpec("test-kv-sink-input-avro-" + randomName(8),
"test-kv-sink-avro-" + randomName(8), Schema.AVRO(Pojo.class),
Pojo.builder().field1("a").field2(2).build()),
new SinkSpec("test-kv-sink-input-kv-string-int-" +
randomName(8), "test-kv-sink-input-kv-string-int-" + randomName(8),
Schema.KeyValue(Schema.STRING, Schema.INT32), new
KeyValue<>("foo", 123)),
- new SinkSpec("test-kv-sink-input-kv-avro-json-" +
randomName(8), "test-kv-sink-input-kv-string-int-" + randomName(8),
- Schema.KeyValue(Schema.AVRO(PojoKey.class),
Schema.JSON(Pojo.class)), new KeyValue<>(PojoKey.builder().field1("a").build(),
Pojo.builder().field1("a").field2(2).build()))
+ new SinkSpec("test-kv-sink-input-kv-avro-json-inl-" +
randomName(8), "test-kv-sink-input-kv-string-int-" + randomName(8),
+ Schema.KeyValue(Schema.AVRO(PojoKey.class),
Schema.JSON(Pojo.class), KeyValueEncodingType.INLINE), new
KeyValue<>(PojoKey.builder().field1("a").build(),
Pojo.builder().field1("a").field2(2).build())),
+ new SinkSpec("test-kv-sink-input-kv-avro-json-sep-" +
randomName(8), "test-kv-sink-input-kv-string-int-" + randomName(8),
+ Schema.KeyValue(Schema.AVRO(PojoKey.class),
Schema.JSON(Pojo.class), KeyValueEncodingType.SEPARATED), new
KeyValue<>(PojoKey.builder().field1("a").build(),
Pojo.builder().field1("a").field2(2).build()))
Review comment:
this is the new test case that covers the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
