jerrypeng commented on a change in pull request #10270:
URL: https://github.com/apache/pulsar/pull/10270#discussion_r616985234
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -269,9 +270,11 @@ public void run() {
try {
processResult(currentRecord, result);
- } catch (Exception e) {
+ result.join();
Review comment:
it is also pointless for create new CompletableFutures for non-async
functions here:
https://github.com/apache/pulsar/blob/master/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java#L74
leads to more GC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
