lhotari commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617370696



##########
File path: pulsar-client-cpp/pkg/deb/docker-build-deb.sh
##########
@@ -21,6 +21,7 @@
 set -e
 
 ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)

Review comment:
       I'd recommend replacing the 2 lines starting with "ROOT_DIR=" with this 
line to determine the ROOT_DIR
   ```
   ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && 
pwd )"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to